AccountMenu: add social login pending/error feedback and lock both providers during auth#223
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add loading spinner and disable buttons for GitHub and Google login
AccountMenu: add social login pending/error feedback and lock both providers during auth
Jul 21, 2026
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
my-code | 9c5cad5 | Commit Preview URL Branch Preview URL |
Jul 21 2026, 05:00 AM |
labelでは勝手に閉じてしまうため
This reverts commit 5166cf5.
na-trium-144
marked this pull request as ready for review
July 21, 2026 04:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub/Google login from
AccountMenucould appear unresponsive during slow auth redirects, with no user feedback and no failure signal. This change adds explicit pending/error UX so users can distinguish “in progress” from “failed”.Pending state + mutual button lock
signingInProviderstate ("github" | "google" | null).loading-spinner) while pending.Centralized social sign-in handler
signInWithSocial(provider)to unify callback URL construction and pending-state handling.Failure feedback
signinErrorMessagestate.