Add newsletter and wiki archives - #61
Merged
Merged
Conversation
The newsletter navigation pointed to one mislabeled Wiki edition, leaving past publications difficult to find.\n\nAdd separate archive pages and responsive year menus so students can browse verified editions while unpublished years remain clearly marked.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Centralize archive content so cards and menus use the same destinations. Add the supplied AY24/25 and AY25/26 Semester 1 newsletters from team-owned Blob storage.
ThePeeKayy
reviewed
Aug 15, 2026
There was a problem hiding this comment.
Pull request overview
This PR introduces internal Newsletter and Wiki archive pages (with “forthcoming” handling) and updates site navigation to point to these new archives, alongside improved dropdown/menu interaction support for desktop and mobile.
Changes:
- Added archive data models + concrete newsletter/wiki archive definitions and a shared archive page renderer.
- Added
/newsletterand/wikiroutes and updated the header to link to them (including mobile sheet behavior/accessibility tweaks). - Enhanced the custom dropdown to better support hover, keyboard navigation, and outside-click dismissal.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/archive.ts | Defines archive types, newsletter/wiki archive data, and a year→anchor helper. |
| components/Header.tsx | Replaces the mislinked “NEWSLETTER” nav item with internal archive routing; adds WIKI nav item and improves mobile menu accessibility/scroll. |
| components/custom-dropdown.tsx | Improves dropdown interaction model (pointer + keyboard), ARIA, and external-link handling. |
| components/ArchivePage.tsx | Adds a reusable archive layout that renders yearly cards with editions or a forthcoming state. |
| app/wiki/page.tsx | Adds the Wiki archive route using the shared ArchivePage. |
| app/newsletter/page.tsx | Adds the Newsletter archive route using the shared ArchivePage. |
Suppressed comments (1)
components/custom-dropdown.tsx:213
z-9999is not a default Tailwind z-index utility (and there is no custom z-index scale defined), so this menu may render behind other UI unexpectedly. Use an arbitrary value (z-[9999]) or a standard token (e.g.z-50).
className={`fixed top-[calc(100%+4px)] left-1/2 z-9999 w-40 origin-top -translate-x-1/2 transform overflow-hidden rounded-md bg-white shadow-lg transition-all duration-300 md:absolute ${
isOpen
? 'scale-y-100 opacity-100'
: 'pointer-events-none scale-y-0 opacity-0'
}`}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Summary
nusc-website-blobVercel Blob storeVerification
npm run build- passes, including compilation, TypeScript, and static generationnpx prettier --check app/newsletter/page.tsx- passesnpx eslint app/newsletter/page.tsx- passes; GitHublintcheck also passesapplication/pdf, 58,495,962 bytes, with SHA-256 matching the supplied PDF