fix: harden the serve_kot endpoint so serving a KOT cannot be forged by arb - #230
Draft
esafwan wants to merge 1 commit into
Draft
fix: harden the serve_kot endpoint so serving a KOT cannot be forged by arb#230esafwan wants to merge 1 commit into
esafwan wants to merge 1 commit into
Conversation
- Restrict serve_kot to POST requests only - Require a kitchen/manager role (URY Captain, URY Manager, System Manager, Administrator) to serve a KOT - Verify the session user is authorized for the KOT's branch and reject cross-branch requests - Record the served timestamp from the server clock instead of trusting the caller-supplied time parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does / Summary
Hardens the
serve_kotAPI endpoint inury/ury/api/ury_kot_display.pyby enforcing POST HTTP method restriction, role-based authorization, branch-level scoping, and server-side timestamp generation.What it solves / Motivation
Key Technical Changes
@frappe.whitelist(methods=["POST"]).URY Manager,URY Captain,System Manager, orAdministrator(raisingPermissionErrorotherwise).URY KOTbranch against caller's branch viagetBranch()(bypassed forSystem ManagerandAdministrator).timeargument with servercurrent_time.strftime("%I:%M:%S %p")to prevent timestamp spoofing while maintaining backward compatibility for call signatures.