feat: add repetition functionality for experiments - #8
Open
jim-junior wants to merge 6 commits into
Open
Conversation
…ding tests Signed-off-by: Beingana Jim Junior <jimjunior854@gmail.com>
Signed-off-by: Beingana Jim Junior <jimjunior854@gmail.com>
…ate stage results Signed-off-by: Beingana Jim Junior <jimjunior854@gmail.com>
Signed-off-by: Beingana Jim Junior <jimjunior854@gmail.com>
Signed-off-by: Beingana Jim Junior <jimjunior854@gmail.com>
Signed-off-by: Beingana Jim Junior <jimjunior854@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds repetition functionality for the HTTP readiness latency and Memory collection benchmarks. It introduces a new field in the
experiment.ymlfile that is applied to experiments as:Theoreticaly it can be added to all experiments(the schema alows this) but aggregation of the results from all the repeated experiment runs has only been implemented for HTTP readiness latency and Memory benchmark.
Further more in the different adaptor.go files for different experiments, a new
GenerateResult()method has been introduced, this is incharge of aggregating all the results from all the repeated experiment runs.A new package
internal/utilshas been added, it includes standard implementations of the Interquartile range math function(and its tests) that is used to remove outliers in the HTTP readiness benchmark that often skew results. In future PRs, i also intend to use this package to transfer certain functions that are highly reused in the code to this package, e.g image pulling functions.