Fix bare except clauses in _pp.py: use except Exception - #101
Open
koteshyelamati wants to merge 1 commit into
Open
Fix bare except clauses in _pp.py: use except Exception#101koteshyelamati wants to merge 1 commit into
koteshyelamati wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 7 bare
except:clauses inppft/_pp.pythat catchBaseException(includingSystemExit,KeyboardInterrupt,GeneratorExit), replacing them withexcept Exception:.Affected methods:
RWorker.connect()(line 219): network send errorsServer.__init__stats check (line 539): time query errorsServer._connect1()(line 617): connection errorsServer._submit()(line 694): thread start errorsServer._run_local()(line 746): local task execution errorsServer._run_remote()(line 781): remote task execution errorsBare
except:clauses are bad practice (PEP 8 / flake8 E722) because they silently swallowKeyboardInterruptandSystemExit, making programs impossible to interrupt cleanly.