Skip to content

Fix the infinite recursion - #25

Merged
UnstoppableMango merged 3 commits into
mainfrom
infinite-recursion
Jul 27, 2026
Merged

Fix the infinite recursion#25
UnstoppableMango merged 3 commits into
mainfrom
infinite-recursion

Conversation

@UnstoppableMango

Copy link
Copy Markdown
Contributor
  • Fix the thing and also refactor
  • Unused param

Copilot AI review requested due to automatic review settings July 27, 2026 05:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors pkgs/default.nix to avoid self-referential evaluation (the likely source of the “infinite recursion”) by removing the config dependency, lifting packages into a local let binding, and rebuilding overlayAttrs/legacyPackages from that local value.

Changes:

  • Refactors callPackage inputs into a tools attrset and uses it to build a shared callPackage.
  • Moves packages into a let binding and updates legacyPackages.packagesTable / overlayAttrs to use it (instead of config.packages).
  • Switches ocaml-protoc packaging to use ocamlPackages.callPackage (but this currently drops required args; see PR comment).

Comment thread pkgs/default.nix
@UnstoppableMango
UnstoppableMango merged commit 85c6a39 into main Jul 27, 2026
5 checks passed
@UnstoppableMango
UnstoppableMango deleted the infinite-recursion branch July 27, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants