Fix review behaviour with committee decision - #3144
Merged
Merged
Conversation
Previously we were trying to create a new review with a review status of 'review_complete' but with no action set which raised a validation error. Also we were using an incorrect field name for the 'Other' checkbox.
pixeltrix
force-pushed
the
fix-committee-decision-reviews
branch
from
July 30, 2026 18:40
9585e3b to
6130282
Compare
Where we have two or more reviews with the same created at timestamp fall back to sorting by highest id first. This sometimes happens within tests where we have frozen the time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Previously we were trying to create a new review with a review status of 'review_complete' but with no action set which raised a validation error.
Also we were using an incorrect field name for the 'Other' checkbox.
Story Link
https://trello.com/c/lYzqyOkR