Fix application-type select - #3136
Open
benjamineskola wants to merge 2 commits into
Open
Conversation
Because the current application type is, by definition, 'existing', it always gets excluded from the list of types — but that makes it impossible to leave the value unchanged when editing. So, for an existing type, the current type's code should always be included as a valid option.
benjamineskola
force-pushed
the
fix-application-type-select
branch
from
July 3, 2026 16:48
2dbb205 to
f6a5182
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Include current application type in config menu when editing
Because the current application type is, by definition, 'existing', it always gets excluded from the list of types — but that makes it impossible to leave the value unchanged when editing. So, for an existing type, the current type's code should always be included as a valid option.
Story Link
https://trello.com/c/CW5Hqn7w/9-cannot-update-the-suffix-for-an-application-type-once-it-has-been-created-as-the-form-requires-the-name-to-be-selected-but-cant