Ensure i_fw_coolant_type is output as a string#4441
Merged
clmould merged 5 commits intoJul 17, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4441 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 151 151
Lines 29673 29676 +3
=======================================
+ Hits 14432 14434 +2
- Misses 15241 15242 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
requested changes
Jul 15, 2026
clmould
left a comment
clmould
left a comment
Collaborator
There was a problem hiding this comment.
Happy with current changes, v minor but could you also make a change in summary.py so that here
it is shown as just Helium without the quotes please? Think it'll be on line 5476 in summary.py
clmould
requested changes
Jul 16, 2026
| Nominal_mean_neutron_load_on_vessel_first-wall_(MW/m^2)__________________ (pflux_fw_neutron_mw)__________ 1.01656659994562149e+00 OP | ||
| # First wall pumping # | ||
| First_wall_coolant_type__________________________________________________ (i_fw_coolant_type)____________ Helium | ||
| First_wall_coolant_type__________________________________________________ (i_fw_coolant_type)____________ 'helium' |
Collaborator
There was a problem hiding this comment.
Suggested change
| First_wall_coolant_type__________________________________________________ (i_fw_coolant_type)____________ 'helium' | |
| First_wall_coolant_type__________________________________________________ (i_fw_coolant_type)____________ 'Helium' |
timothy-nunn
commented
Jul 16, 2026
clmould
requested changes
Jul 16, 2026
clmould
approved these changes
Jul 16, 2026
clmould
deleted the
4422-i_fw_coolant_type-value-cant-be-parsed-in-the-mfile
branch
July 17, 2026 12:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
i_fw_coolant_typewas being output asHeliumrather than'helium'(notice the quotes) PROCESS was trying to treat it as a float, not a string.