♻️ Refactor some radiation methods for clarity#4219
Open
chris-ashe wants to merge 15 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4219 +/- ##
==========================================
- Coverage 48.86% 48.86% -0.01%
==========================================
Files 151 151
Lines 29461 29431 -30
==========================================
- Hits 14397 14382 -15
+ Misses 15064 15049 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
force-pushed
the
line_brem_profile_bug
branch
from
May 28, 2026 14:09
439cbc9 to
4c7c3ce
Compare
…nd improve comments Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…sity` for clarity
…n imprad_profile method Co-authored-by: Copilot <copilot@github.com>
…` for clarity and update references
…p_compiled` for clarity
… accuracy in parameter types and documentation Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…mathematical notation Co-authored-by: Copilot <copilot@github.com>
…ions Co-authored-by: Copilot <copilot@github.com>
…y and update related tests
chris-ashe
force-pushed
the
line_brem_profile_bug
branch
from
June 17, 2026 10:17
03ddd71 to
e4e975a
Compare
chris-ashe
changed the title
chris-ashe
marked this pull request as ready for review
July 10, 2026 13:22
…ty and update related calculations
timothy-nunn
requested changes
Jul 10, 2026
|
|
||
| @njit(cache=True) | ||
| def _zav_of_te_compiled( | ||
| def calculate_average_charge_at_temp_compiled( |
Collaborator
There was a problem hiding this comment.
Suggested change
| def calculate_average_charge_at_temp_compiled( | |
| def _calculate_average_charge_at_temp_compiled( |
I would prefer to keep this hidden
Comment on lines
+477
to
478
| indices = np.digitize(temp_electron_kev, bins) | ||
| indices[indices >= bins.shape[0]] = bins.shape[0] - 1 |
Collaborator
There was a problem hiding this comment.
temp_electron_kev is typed as allowed to be a float but this function would fail here because indices will be a np.int64 which you cannot do item assignment to
Comment on lines
+517
to
+518
| nd_electron_profile: np.array | float, | ||
| temp_electron_profile_kev: np.array | float, |
Collaborator
There was a problem hiding this comment.
Again, I don't think these will work as floats because indexing wont work
timothy-nunn
requested changes
Jul 14, 2026
Comment on lines
+380
to
+388
| def z2index(zimp, data: DataStructure) -> int: | ||
| for i in range(len(data.impurity_radiation.impurity_arr_label)): | ||
| if zimp == data.impurity_radiation.impurity_arr_z[i]: | ||
| return i | ||
|
|
||
| # Should only get here if there is a problem | ||
| raise ProcessValueError( | ||
| "Element with the given charge is not in the impurity array", zimp=zimp | ||
| ) |
Collaborator
There was a problem hiding this comment.
I can't see this function being used anywhere
|
|
||
| Parameters | ||
| ---------- | ||
| imp_element_index |
Collaborator
There was a problem hiding this comment.
There are : missing in the docstrings added by this PR. E.g.
Suggested change
| imp_element_index | |
| imp_element_index: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: