Skip to content

fix(graphrunner): select Bazel dependency mode for BUG-022 - #302

Draft
sbalabanov wants to merge 1 commit into
mainfrom
sbalabanov/bug-022
Draft

fix(graphrunner): select Bazel dependency mode for BUG-022#302
sbalabanov wants to merge 1 commit into
mainfrom
sbalabanov/bug-022

Conversation

@sbalabanov

@sbalabanov sbalabanov commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Fix BUG-022 by making bzlmod_enabled authoritative for Bazel query and hashing behavior.

Use case:

  • A repository still uses WORKSPACE and sets bzlmod_enabled: false. Previously Tango selected a //external query without forcing Bazel into WORKSPACE mode, so Bazel could use Bzlmod defaults and fail the query or omit legacy external dependencies. This change explicitly disables Bzlmod and enables WORKSPACE for that repository.

Changes:

  • Select explicit Bazel dependency-mode flags for Bzlmod and WORKSPACE queries.
  • Reject conflicting configured mode flags and cover mode resolution and command construction.

Generated by the 🪄 pr-create skill in devexp-agent-marketplace

Test Plan

  • Unit tests cover both dependency modes, command construction, and conflicting flags; CI passes.

Revert Plan

  • Revert this PR.

Issues

T3-BUG-022

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbalabanov
sbalabanov marked this pull request as ready for review August 26, 2026 18:32
@sbalabanov
sbalabanov requested review from a team as code owners August 26, 2026 18:32
@sbalabanov
sbalabanov marked this pull request as draft August 26, 2026 19:17

@sbalabanov sbalabanov left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update PR description with the example of use case of the bug the PR is fixing

@sbalabanov

Copy link
Copy Markdown
Contributor Author

Addressed review 5035995994 by adding a concise, concrete WORKSPACE-mode use case to the BUG-022 PR description. This was metadata-only; the current HEAD remains 5acb73fd1ce4b9f9701b760fcce434690b9a8f21.

[addressed by agent]

Summary:
Intent:
- Fix BUG-022 by making bzlmod_enabled authoritative for Bazel query and hashing behavior.

Changes:
- Select explicit Bazel dependency-mode flags for Bzlmod and WORKSPACE queries.
- Reject conflicting configured mode flags and cover mode resolution and command construction.

---

<sub>Generated by the 🪄 pr-create skill in devexp-agent-marketplace</sub>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants