fix(controller): preserve AllTargetsFiles change types for BUG-015 - #298
Open
sbalabanov wants to merge 1 commit into
Open
fix(controller): preserve AllTargetsFiles change types for BUG-015#298sbalabanov wants to merge 1 commit into
sbalabanov wants to merge 1 commit into
Conversation
|
|
sbalabanov
marked this pull request as ready for review
August 26, 2026 18:32
sbalabanov
marked this pull request as draft
August 26, 2026 19:17
sbalabanov
commented
Aug 27, 2026
sbalabanov
left a comment
sbalabanov
left a comment
Contributor
Author
There was a problem hiding this comment.
Simplify the PR description, include use case example of the bug the PR fixes
Contributor
Author
|
Simplified the PR description and added a concrete [addressed by agent] |
sbalabanov
commented
Aug 27, 2026
Summary: BUG-015 preserves protocol ChangeType semantics when an AllTargetsFiles global trigger fires. Intent: - Keep revision membership changes distinguishable from global invalidation. - Return complete old and new target payloads for targets present in both revisions. Changes: - Retain ordinary NEW and DELETED results before promoting shared targets to distance-zero CHANGED. - Apply identical classification behavior to chunk-backed and TGB-backed comparisons. - Cover stable, hash-changed, added, and deleted targets across both graph formats. --- <sub>Generated by the 🪄 pr-create skill in devexp-agent-marketplace</sub>
sbalabanov
force-pushed
the
sbalabanov/bug-015
branch
from
August 27, 2026 22:02
1eeb5a1 to
d307022
Compare
sbalabanov
marked this pull request as ready for review
August 27, 2026 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix BUG-015 by preserving
NEWandDELETEDchange types when anAllTargetsFilesglobal trigger changes.Previously, global invalidation could overwrite every result as
CHANGED. For example, if.bazelrcchanges in the same revision that adds//service:newand deletes//service:old, callers must still receiveNEWfor the added target andDELETEDfor the removed target; only targets present in both revisions should be promoted to distance-zeroCHANGED.The fix applies the same classification behavior to chunk-backed and TGB-backed graph comparisons.
Test Plan
Issues
T3-BUG-015