fix(api)!: remove roots_only output option (BUG-021) - #294
Merged
Conversation
|
|
sbalabanov
marked this pull request as ready for review
August 26, 2026 18:32
sbalabanov
marked this pull request as draft
August 26, 2026 19:17
sbalabanov
commented
Aug 26, 2026
sbalabanov
left a comment
sbalabanov
left a comment
Contributor
Author
There was a problem hiding this comment.
Instead just remove roots_only from the API contract. Do not bother with backwards compatibility.
sbalabanov
force-pushed
the
sbalabanov/bug-021
branch
from
August 26, 2026 20:34
1c1fc01 to
5c72105
Compare
sbalabanov
changed the title
Contributor
Author
|
Addressed the review in 5c72105 by removing OutputConfig.roots_only from the proto contract and regenerating the Go and YARPC bindings. The prior controller filtering implementation and tests were dropped, so BUG-021 now performs the requested contract removal without a compatibility shim. [addressed by agent] |
sbalabanov
commented
Aug 26, 2026
sbalabanov
force-pushed
the
sbalabanov/bug-021
branch
from
August 26, 2026 21:59
5c72105 to
2e49c71
Compare
sbalabanov
marked this pull request as ready for review
August 26, 2026 22:05
sbalabanov
marked this pull request as draft
August 26, 2026 22:15
sbalabanov
force-pushed
the
sbalabanov/bug-021
branch
from
August 26, 2026 22:15
2e49c71 to
c938c41
Compare
sbalabanov
marked this pull request as ready for review
August 26, 2026 23:03
sbalabanov
marked this pull request as draft
August 26, 2026 23:19
sbalabanov
marked this pull request as ready for review
August 26, 2026 23:35
xytan0056
reviewed
Aug 27, 2026
sbalabanov
force-pushed
the
sbalabanov/bug-021
branch
from
August 27, 2026 21:16
c938c41 to
b3a1d61
Compare
xytan0056
approved these changes
Aug 27, 2026
BUG-021 Summary: - Remove roots_only from the Tango API contract instead of implementing it. - Reserve the removed field number 4 and field name roots_only to prevent incompatible protobuf reuse. - Drop the controller filtering changes and tests that depended on the obsolete option. - Regenerate the committed Go and YARPC protobuf bindings. Backwards compatibility is intentionally not provided for the removed API, while its wire identifiers remain permanently reserved. BREAKING CHANGE: OutputConfig.roots_only has been removed from tango.proto and the generated Go/YARPC bindings.
sbalabanov
force-pushed
the
sbalabanov/bug-021
branch
from
August 27, 2026 22:53
b3a1d61 to
700acfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix BUG-021 by removing the unsupported
OutputConfig.roots_onlyoption from the Tango API and regenerated Go/YARPC bindings.Because Tango has not reached a major release, this intentionally makes the breaking protobuf change directly without reserving the removed field name or number.
Test Plan
PATH=/tmp/tango-proto-tools/bin:$PATH make proto(run twice; deterministic output confirmed)go test ./controller ./mapper ./internal/mapper ./tangopb/..../tools/bazel build //proto:tangopb_go_proto //tangopb:tangopb./tools/bazel test //controller:controller_test --test_output=errorsBreaking Change
OutputConfig.roots_onlyis removed from the protobuf contract and generated Go/YARPC bindings.