Skip to content

fix(repomanager): sanitize reused workers for BUG-003 - #293

Merged
sbalabanov merged 1 commit into
mainfrom
sbalabanov/bug-003
Aug 27, 2026
Merged

fix(repomanager): sanitize reused workers for BUG-003#293
sbalabanov merged 1 commit into
mainfrom
sbalabanov/bug-003

Conversation

@sbalabanov

@sbalabanov sbalabanov commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

BUG-003 prevents changes left by one request from affecting the next request that reuses the same repository worker.

  • Before the next git checkout and workspace changes, reset tracked files and remove untracked, ignored, and submodule changes.
  • If the worker cannot be cleaned, delete and clone it again instead of reusing it.

Test Plan

  • Verified that a failed request leaving staged, tracked, untracked, and ignored changes is followed by a clean checkout.
  • Verified that cleanup failure recreates the worker.

AI Verification

Validated at 31d76b4 on Aug 26 18:11 UTC · 6 files analyzed · 1s

Validator Status Issues
go-lint not_applicable 0
go-proto-lint not_applicable 0
go-coverage not_applicable 0
android-lint not_applicable 0
ios-test not_applicable 0
go-thrift-lint not_applicable 0
android-coverage not_applicable 0
java-coverage not_applicable 0
ios-lint not_applicable 0
uber-one not_applicable 0
web not_applicable 0
diff-template not_applicable 0
java-lint not_applicable 0
custom not_applicable 0
ureview completed 0

0 issues detected

Skipped validators: claude · EngWiki

Issues

T3-BUG-003

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbalabanov
sbalabanov marked this pull request as ready for review August 26, 2026 18:32
@sbalabanov
sbalabanov requested review from a team as code owners August 26, 2026 18:32
@sbalabanov
sbalabanov marked this pull request as draft August 26, 2026 19:17

@sbalabanov sbalabanov left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update PR description to use concrete wording, like "git checkout" instead of "materialization". Simplify.

@sbalabanov
sbalabanov marked this pull request as ready for review August 26, 2026 23:57
@sbalabanov

Copy link
Copy Markdown
Contributor Author

Addressed review 5036024575 at HEAD 31d76b4006bea0a98fbd0d26714d2162c864b966. Simplified the BUG-003 description to explain the concrete git checkout, cleanup, and worker recreation behavior. This was metadata-only; no code or commit changes were made.

[addressed by agent]

Comment thread core/git/git.go
Summary:
Intent:
- Prevent BUG-003 from exposing dirty or failed materializations to later requests.

Changes:
- Restore tracked, untracked, ignored, and submodule state before reusing a worker.
- Recreate workers whose cleanup cannot be verified and cover both cleanup paths with regression tests.
@sbalabanov
sbalabanov merged commit 58649cd into main Aug 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants