fix(controller): detect AllTargetsFiles deletion (BUG-013) - #292
Merged
Conversation
Summary: BUG-013 preserves the complete configured AllTargetsFiles state across revisions so additions and deletions trigger global invalidation. Intent: - Detect configured global-trigger files appearing or disappearing. - Compare the full configured key and hash state symmetrically. Changes: - Represent configured paths absent from a revision with an explicit empty hash value. - Compare both AllTargetsFileHashes maps as complete sets. - Cover addition, deletion, missing-side, and matching-state behavior. --- <sub>Generated by the 🪄 pr-create skill in devexp-agent-marketplace</sub>
|
|
sbalabanov
marked this pull request as ready for review
August 26, 2026 18:32
sbalabanov
marked this pull request as draft
August 26, 2026 19:17
sbalabanov
commented
Aug 27, 2026
sbalabanov
left a comment
sbalabanov
left a comment
Contributor
Author
There was a problem hiding this comment.
Simplify PR description, add use case example of the bug it is fixing
Contributor
Author
|
Simplified the PR description and added a concrete [addressed by agent] |
sbalabanov
marked this pull request as ready for review
August 27, 2026 21:23
xytan0056
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix BUG-013 by detecting when a configured
AllTargetsFilespath is added or deleted between revisions.Previously, Tango compared only files present in each revision, so deleting a global trigger file could be missed. For example, if
.bazelrcis configured as anAllTargetsFilesentry and is removed in a new revision, every target must be invalidated because the repository-wide build configuration changed.The fix records configured paths even when absent and compares the complete old and new path/hash sets symmetrically.
Test Plan
Issues
T3-BUG-013