Add StatusResult type alias for consistent naming#372
Merged
Conversation
Add StatusResult as a type alias for request.CurrentState in the gateway controller, matching the naming convention used by LandResult and other controller return types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ubettigole
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
ubettigole
changed the title
behinddwalls
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the Land and Cancel controllers return a LandResult and CancelResult, respectively. The StatusResult is returning a request.CurrentState struct, which causes inconsistency in the naming convention. I'm adding a StatusResult type alias for request.CurrentState in the status controller, matching the naming convention used by other controllers.
I'm choosing to do this, rather than creating a separate entity.StatusResult struct with the same fields as request.CurrentState to avoid the duplication and boilerplate mapping code that would be required. If the desired fields in the request.CurrentState struct and Status() response diverge in the future, we can create a separate entity.StatusResult, like the other endpoints/controllers have.
Test Plan
Unit tests