Rewrite Nix flake - #341
Merged
Merged
Conversation
Owner
|
Thanks a lot! This is awesome! |
turion
reviewed
Jun 26, 2024
turion
reviewed
Jun 26, 2024
Owner
|
The test failure may simply be the Github MacOS runner. For some reason, some concurrency and timing stuff from monad-schedule doesn't work on MacOS so well. |
ners
force-pushed
the
flake
branch
3 times, most recently
from
June 28, 2024 08:10
9f415c0 to
5a942e5
Compare
turion
reviewed
Jul 1, 2024
turion
reviewed
Jul 1, 2024
ners
force-pushed
the
flake
branch
9 times, most recently
from
July 14, 2024 09:00
45e4ffc to
9ea3c6b
Compare
turion
reviewed
Jul 15, 2024
turion
reviewed
Jul 15, 2024
turion
reviewed
Jul 15, 2024
turion
reviewed
Jul 15, 2024
turion
reviewed
Jul 15, 2024
turion
reviewed
Jul 15, 2024
Owner
|
I added a few commits to document everything. I needed this in order to fully understand what's going on. I believe I have it now. In case you can spot a blatant misunderstanding, feel free to call it out :) |
1 task
turion
enabled auto-merge
July 16, 2024 08:20
Owner
|
Fantastic! Again, thanks a lot, this makes rhine development a lot more productive. And I've learned a lot along the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at ZuriHac: the new and improved Rhine flake! ✨
Design goals:
This is the sort of flake I wish to import when working on Rhine-powered projects. Until now I've had to copy around a bunch of boilerplate.