MLIR: Nested/Expression aggregate logic - #806
Merged
Merged
Conversation
rjb32
approved these changes
Aug 21, 2026
cyrusknopf
force-pushed
the
fix/mlir/nested-aggregates
branch
from
August 21, 2026 11:13
4b90d5a to
1537da3
Compare
cyrusknopf
force-pushed
the
fix/mlir/nested-aggregates
branch
from
August 21, 2026 12:48
1537da3 to
87f41ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, expressions that contained aggregates were not treated as aggregates.
This PR adds logic to ensure that aggregates and grouping keys that are nested in an arbitrary expression are generated correctly.