MLIR: resolve the count(*) input column by query order - #805
Merged
Conversation
rjb32
force-pushed
the
fix/mlir/count-wildcard-input-column
branch
from
August 19, 2026 23:25
77360dd to
e726183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
count(*) took its input column from an unordered map, so which variable it counted varied with the addresses of the variables and was never checked to hold the rows in flight; it now takes the first variable of the query bound to a column at the insertion point, tested on
MATCH (a), (b) RETURN count(*)andMATCH (a), (b) RETURN b, count(*).