Conversation
sprihozhiy
requested changes
Oct 2, 2020
sprihozhiy
left a comment
sprihozhiy
left a comment
Collaborator
There was a problem hiding this comment.
Try to read again about the fundamentals of HTML on MDN and rewrite your code, please.
https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML
| @@ -0,0 +1,34 @@ | |||
| <html> | |||
Collaborator
There was a problem hiding this comment.
Missing above the <html> tag
|
|
||
|
|
||
| <head> | ||
|
|
Collaborator
There was a problem hiding this comment.
<head> should has at least <title> tag
|
|
||
| <body> | ||
| <h1>Welcome to the <b>sports store</b></h1> | ||
| <h2><hr>Hear you will find all your sports need <p></h2> |
Collaborator
There was a problem hiding this comment.
What was the purpose of putting <hr> and <p> tags inside of the <h2> tag?
| <body> | ||
| <h1>Welcome to the <b>sports store</b></h1> | ||
| <h2><hr>Hear you will find all your sports need <p></h2> | ||
| <ul> |
Collaborator
There was a problem hiding this comment.
Inside of this tag can be only a list item tag (<li>)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe i understand now