Document dead refresh_all_providers_on_menu_open (SBS-1070) - #402
Document dead refresh_all_providers_on_menu_open (SBS-1070)#402tsouth89 wants to merge 1 commit into
Conversation
SETTINGS_JSON.md marked the leftover flag as Safe to edit. Nothing reads it — only settings round-trip — so document it as legacy compatibility. Co-authored-by: Tyler <tyler@southboundsoftware.com>
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ceiling | c123700 | Commit Preview URL Branch Preview URL |
Aug 23 2026, 10:22 PM |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6c54c210-338c-4fbd-9bfa-c3596a43fbf2) |
2 participants
Summary
SETTINGS_JSON.mdstill describedrefresh_all_providers_on_menu_openas Safe to edit ("force-refresh when a tray/menu surface opens"). Nothing reads the flag — settings only persist and round-trip it. GeneralTab already asserts the toggle is absent.This documents the field as an ignored legacy compatibility key (same pattern as SBS-1052 /
float_bar_show_cost/menu_bar_*) and updates the matching rustdoc and TypeScript snapshot comment so they no longer claim the flag is effective. No Settings UI was added; none exists for this key.Related issue
Cites SBS-1070.
Affected areas
Validation
Hosted CI is the real gate. On this revision:
CI / Frontend— passedCI / Rust / shared— passed (windows-latest)CI / Rust / desktop— passed (windows-latest)CI / Rust— passedgithub-advanced-security/ "Code scanning AI findings" failed withSessionModelError: You are not licensed to use Copilot. That is a Copilot Autofind license failure, not a finding in this docs/comment change.Local Windows
scripts\local-check.ps1is not run on this Linux agent.powershell.exe -ExecutionPolicy Bypass -NoProfile -File scripts\local-check.ps1(Windows script; not run on this Linux agent)cargo fmt --all --check, andcargo test --manifest-path rust/Cargo.toml(1185 lib + 32 bin).UI / tray proof
No UI or tray pixels changed. The GeneralTab toggle is already absent; this only stops the docs from saying the flag works.
Notes for reviewers
The field stays in
settings.json/Settingsso existing files still load. This does not remove the dead key or invent a refresh-on-menu-open UI.Do not merge.
Note
Document
refresh_all_providers_on_menu_openas a legacy, unread flagUpdates doc comments and notes across Rust settings, TypeScript bridge types, and the settings JSON reference to mark
refresh_all_providers_on_menu_openas a legacy compatibility field that nothing reads. Opening a tray or menu surface does not force-refresh providers.Macroscope summarized c123700.