Prepare Ceiling 1.5.17 - #181
Merged
Merged
Conversation
Bump the five version files plus BUILD_NUMBER, and date the changelog section covering everything merged since v1.5.16: Windows notification delivery (#180), Simplified Chinese (#113, #130), provider login flows (#179), multi-account API value scans (#176), the Cursor Auto/API strip fix (#175), and Store submission automation (#177, #178). Also stop release-doctor from dying on its own GitHub check. Under $ErrorActionPreference = "Stop" a native command writing to stderr raises a terminating error, so `gh release view` reporting "release not found" killed the script before it printed a summary. That is the expected answer for every run before the tag exists, which meant the validation step RELEASING.md requires could never pass at the point it is meant to run, and a real failure looked exactly like the normal one. The block already redirected stderr and branched on $LASTEXITCODE; it just never got the chance. Scope ErrorActionPreference around the call so the exit code decides, as intended.
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ceiling | 0d7d04c | Commit Preview URL Branch Preview URL |
Jul 29 2026, 11:13 PM |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughCeiling 1.5.17 release metadata is synchronized across changelog, package manifests, Tauri configuration, Rust metadata, and build variables. The release doctor now handles missing GitHub releases without terminating while preserving exit-code checks. ChangesRelease preparation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the Ceiling 1.5.17 release by bumping versions across the Rust + Tauri + frontend surfaces, adding a dated changelog entry, and fixing release-doctor.ps1 so pre-tag runs don’t terminate early when gh release view reports the expected “release not found” case.
Changes:
- Bump version references to 1.5.17 (and
BUILD_NUMBER119) across release/version files and manifests. - Add a 1.5.17 dated entry to
CHANGELOG.md. - Scope PowerShell
$ErrorActionPreferencearoundgh release viewso the script can continue and print its summary on expected pre-tag stderr output.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| version.env | Bumps marketing version to 1.5.17 and build number to 119. |
| scripts/release-doctor.ps1 | Prevents expected pre-tag gh release view stderr from terminating the script under ErrorActionPreference=Stop. |
| rust/Cargo.toml | Updates shared Rust crate version to 1.5.17. |
| CHANGELOG.md | Adds the 1.5.17 release entry dated 2026-07-29. |
| Cargo.lock | Updates locked package versions for the two workspace crates to 1.5.17. |
| apps/desktop-tauri/src-tauri/tauri.conf.json | Updates Tauri app version to 1.5.17. |
| apps/desktop-tauri/src-tauri/Cargo.toml | Updates Tauri Rust crate version to 1.5.17. |
| apps/desktop-tauri/package.json | Updates frontend package version to 1.5.17. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and dated changelog for 1.5.17.
Version
version.env(plusBUILD_NUMBER118 → 119), both Rust manifests,Cargo.lock,package.json, andtauri.conf.jsonall move to 1.5.17.What ships
Also: release-doctor could never pass before the tag existed
gh release viewreporting "release not found" is the expected answer on every pre-tag run, but under$ErrorActionPreference = "Stop"a native command writing to stderr raises a terminating error. The doctor died there and never printed its summary, solocal-check.ps1 -All -Version <version>— step 3 ofdocs/RELEASING.md, which runs before the tag is created — always failed, and a genuine failure was indistinguishable from the normal case.The block already redirected stderr and branched on
$LASTEXITCODE; it just never got the chance to. ScopingErrorActionPreferencearound the call lets the exit code decide, as intended.Before: died at line 239, no summary, exit 1.
After:
3 warning(s). Release doctor passed.exit 0, with the warnings being the expected pre-tag ones (no local tag, no local assets dir).Validation
scripts\local-check.ps1 -All -Version 1.5.17passes end to end, exit 0:clippy -D warningsgatesio.github.tsouth89.ceiling, changelog mentions 1.5.17Note before tagging
This is the first tag to exercise Microsoft Store submission for real.
MICROSOFT_STORE_SUBMISSION_ENABLEDistrue, set right after the validation-only run succeeded, so the gate in #177 was honoured — but the automated submission path itself has not run in a real release.Summary by CodeRabbit
New Features
Release