test: share one awaited resetTestDb() helper across all DB tests - #28
Merged
Conversation
The IndexedDB reset dance was hand-rolled in 21 test files in three
diverging forms. ~10 used a fire-and-forget variant — `_resetDbForTests()`
and `indexedDB.deleteDatabase('daycipher')` with neither awaited — exactly
the race `_resetDbForTests`'s own doc-comment warns "leaks state between
tests." (backup.test.ts also had an un-awaited reset mid-test, racing the
following importAll.)
Add src/test/resetDb.ts exporting `resetTestDb()` — awaits the connection
close, then awaits the delete — and route every test through it
(`beforeEach(resetTestDb)`). One correct implementation; the racy variants
are gone and the duplicated boilerplate collapses to a single import.
typecheck ✓ · lint --max-warnings 0 ✓ · 290 tests ✓ · build ✓
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latent fix surfaced while reviewing #26/#27 (not specific to either).
The IndexedDB reset dance was hand-rolled in 21 test files in three diverging forms. ~10 used a fire-and-forget variant —
_resetDbForTests()andindexedDB.deleteDatabase('daycipher')with neither awaited — exactly the race_resetDbForTests's own doc-comment warns "leaks state between tests."backup.test.tsalso reset un-awaited mid-test, racing the followingimportAll.Change
src/test/resetDb.tsexportingresetTestDb()— awaits the connection close, then awaits the delete.beforeEach(resetTestDb);await resetTestDb()where extra setup follows). One correct implementation; the racy variants and ~16 lines/file of duplicated boilerplate are gone.Verification
typecheck ✓ · lint
--max-warnings 0✓ · 290 tests ✓ · build ✓. Pure test-mechanism refactor — no app code touched, test count unchanged.🤖 Generated with Claude Code