fix: resolve stable static solver names - #27
Closed
seveibar wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 18, 2026
Contributor
Author
|
Closing this in favor of the existing instance getSolverName() contract. GenericSolverDebugger already calls solver.getSolverName() everywhere it displays a class-level solver name, so no solver-utils API change is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add optional BaseSolver.solverName constructor metadata\n- resolve explicit static names before legacy instance methods or constructor.name\n- use the shared resolver throughout the generic debugger UI\n- support package-local solvers that do not implement getSolverName()\n\n## Why\nRunframe minifies its standalone bundles, so JavaScript constructor names can become labels such as aby. Solver packages can now publish a stable readable name without relying on a preserved class identifier or wrappers in core.\n\n## Companion source PRs\n- calculate-packing#123: https://github.com/tscircuit/calculate-packing/pull/123\n- matchpack#222: https://github.com/tscircuit/matchpack/pull/222\n- tscircuit-autorouter#2158: https://github.com/tscircuit/tscircuit-autorouter/pull/2158\n- copper-pour-solver#81: https://github.com/tscircuit/copper-pour-solver/pull/81\n- create-fdm-enclosure#7: https://github.com/tscircuit/create-fdm-enclosure/pull/7\n- fanout-solver#75: https://github.com/tscircuit/fanout-solver/pull/75\n- schematic-trace-solver#824: https://github.com/tscircuit/schematic-trace-solver/pull/824\n\n## Verification\n- bun test (26 passing)\n- bunx tsc --noEmit\n- bun run build\n- bun run format:check\n- built integration check against all 16 solver exports used by core