Rotate vertical inline net labels in the debug visualization - #794
Merged
Conversation
A vertical trace's inline label was drawn horizontally across the wire in visualize() output. graphics-debug texts now support rotation, so pass 90 (counter-clockwise, bottom-to-top) for y-axis labels. Needs graphics-debug with Text.rotation (tscircuit/graphics-debug#228); the devDependency bump lands here once that releases. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #792. A vertical trace's inline label was drawn horizontally across the wire in
visualize()output — flagged during review:SPI_SCKlying across the vertical wireSPI_SCKreading bottom-to-top alongside itgraphics-debug texts support rotation as of 0.0.98 (graphics-debug#228), so
visualize()passesrotation: 90(counter-clockwise, bottom-to-top) for y-axis labels, and the devDependency is bumped^0.0.96→^0.0.98.Only the debug visualization changes — solver output (
inlineNetLabelPlacements) is untouched. One snapshot regenerated.bun test: 174 pass / 0 fail against the published package. Typecheck clean.Note: independent of #793 (overhang sliding); the two touch different code and can merge in either order.
🤖 Generated with Claude Code