fix(quad): bound corner silkscreen arms to prevent pad overlap on narrow variants - #808
Open
rudra496 wants to merge 1 commit into
Open
fix(quad): bound corner silkscreen arms to prevent pad overlap on narrow variants#808rudra496 wants to merge 1 commit into
rudra496 wants to merge 1 commit into
Conversation
…row variants Fixes tscircuit#734 by calculating distance to outermost pads along horizontal and vertical sides, bounding corner silkscreen arm length to ensure positive silk-to-pad clearance.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #734.
Previously, corner silkscreen paths on quad packages were assigned a fixed arm length (`csz = pw * 2`) from `(±w/2, ±h/2)`. On narrow-body variants (such as `tqfp32_w7` and `tqfp48_w7`), the inward arms crossed through the outermost pad copper, resulting in negative silk-to-pad clearance.
Changes
Verification