fix(lcc): default pitch to standard 1.27mm to eliminate overlapping pads - #805
Open
rudra496 wants to merge 1 commit into
Open
fix(lcc): default pitch to standard 1.27mm to eliminate overlapping pads#805rudra496 wants to merge 1 commit into
rudra496 wants to merge 1 commit into
Conversation
Fixes tscircuit#794 by defaulting parameters.p to 1.27mm in lcc(), preventing adjacent 0.6mm pads from overlapping on 0.5mm default quad pitches.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #794.
Previously, calling `fp.string("lccN")` without an explicit pitch inherited the generic quad default pitch of `0.5mm`. Because LCC pad width (`pw`) defaults to `0.6mm`, adjacent pads overlapped by `0.1mm`, generating an electrical short on emitted PCBs.
Changes
Verification