Skip to content

fix(vson): add standard default dimensions to vson_def - #803

Open
rudra496 wants to merge 2 commits into
tscircuit:mainfrom
rudra496:fix/vson-default-parameters
Open

fix(vson): add standard default dimensions to vson_def#803
rudra496 wants to merge 2 commits into
tscircuit:mainfrom
rudra496:fix/vson-default-parameters

Conversation

@rudra496

Copy link
Copy Markdown

Summary

Fixes #782.

Previously, `vson_def` declared `p`, `w`, `grid`, `pinw`, and `pinh` without default values. Calling `fp.string("vson8")` failed with a raw Zod parse error.

Changes

  1. Default Dimensions: Added standard package default dimensions to `vson_def` (`p: "0.5mm"`, `w: "3.3mm"`, `grid: "3x3mm"`, `pinw: "0.6mm"`, `pinh: "0.24mm"`), matching sibling `son` and `wson` footprint behavior.
  2. Unit Tests: Added `tests/vson-bare-string.test.ts` verifying that bare string `vson8` and `vson` render 8 pads without error.

Verification

  • `bun test tests/vson-bare-string.test.ts` (2/2 passing).

Fixes tscircuit#782 by defaulting p, w, grid, pinw, and pinh in vson_def, matching son/wson behavior and enabling bare string vson8 rendering.
Copilot AI lite review requested due to automatic review settings August 15, 2026 20:37
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vson8 throws a raw parse error while son8/wson8 render from a bare name

2 participants