Fix custom-symbol port directions and trace endpoints - #3309
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
marked this pull request as ready for review
August 20, 2026 07:34
ShiboSoftwareDev
approved these changes
Aug 20, 2026
imrishabh18
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
directionvalues on ports inside React and Circuit JSON custom symbolsside_of_componentfrom the same explicit direction instead of fallback schematic-box metadataDMT6007LFG_7reproduction and schematic snapshotsRoot cause
Port direction
A chip can retain fallback schematic-box placement metadata while rendering a custom symbol. Port rendering previously allowed that fallback side to override the custom symbol port's explicit
direction. The emittedschematic_portcould therefore face the wrong way, causing net labels such asGATEto be placed inward.Disconnected trace endpoint
The schematic solver can project a custom-symbol boundary port onto its routing-box edge. Core already reconnects solver-adjusted endpoints to authoritative
schematic_portcenters for text-expanded components, but custom symbols without text-expanded bounds were excluded. This left a visible gap between theSOURCEtrace and the imported MOSFET's S3 port.The endpoint reconciliation now also recognizes genuine React and Circuit JSON custom symbols. It remains restricted to ports on or outside the normal symbol boundary, so it does not draw traces through symbols that intentionally declare interior ports.
Validation
DMT6007LFG_7regression with and without traces/net labelsbunx tsc --noEmit