Skip to content

repro : via-in-pad allowance ignored by clearance checks - #231

Closed
GokulPandi-M wants to merge 1 commit into
tscircuit:mainfrom
GokulPandi-M:codex/repro-allowed-via-in-pad-clearance
Closed

repro : via-in-pad allowance ignored by clearance checks#231
GokulPandi-M wants to merge 1 commit into
tscircuit:mainfrom
GokulPandi-M:codex/repro-allowed-via-in-pad-clearance

Conversation

@GokulPandi-M

Copy link
Copy Markdown

What happens

When a board sets is_via_in_pad_allowed: true, checkViasInPads correctly accepts vias inside an SMD pad. However, checkViaPadClearance ignores the same board setting and reports one false clearance error for every contained via.

This affects valid thermal-pad footprints such as LCSC C7728, where thermal vias intentionally sit inside the exposed pad.

Reproduction

The test uses raw Circuit JSON containing:

  • a board with via-in-pad explicitly allowed
  • one exposed SMD pad
  • four thermal vias fully contained by that pad

It verifies that the placement check returns no errors while the clearance check incorrectly returns four errors.

Four false via-to-pad clearance errors

This is a reproduction-only PR and does not include a fix.

Checks

  • bun test — 184 passed, 0 failed
  • focused via-in-pad and via-clearance tests — 6 passed, 0 failed
  • bunx tsc --noEmit
  • bun run build

bun run format:check reports only the repository's existing size-limit warnings for three large JSON fixtures; the added test passes Biome directly.

@GokulPandi-M GokulPandi-M changed the title Reproduce via-in-pad allowance ignored by clearance checks repro : via-in-pad allowance ignored by clearance checks Aug 21, 2026

@imrishabh18 imrishabh18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share the footprint which you used to create this, the via should be having the connectivity reference to the pads.

@GokulPandi-M

GokulPandi-M commented Aug 21, 2026

Copy link
Copy Markdown
Author

ig ,i need to close this pr , coz the error was expected in my case btw sorry for this and thanks for the review!! @imrishabh18

@GokulPandi-M
GokulPandi-M deleted the codex/repro-allowed-via-in-pad-clearance branch August 21, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants