repro : via-in-pad allowance ignored by clearance checks - #231
Closed
GokulPandi-M wants to merge 1 commit into
Closed
repro : via-in-pad allowance ignored by clearance checks#231GokulPandi-M wants to merge 1 commit into
GokulPandi-M wants to merge 1 commit into
Conversation
imrishabh18
reviewed
Aug 21, 2026
imrishabh18
left a comment
Member
There was a problem hiding this comment.
Share the footprint which you used to create this, the via should be having the connectivity reference to the pads.
Author
|
ig ,i need to close this pr , coz the error was expected in my case btw sorry for this and thanks for the review!! @imrishabh18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happens
When a board sets
is_via_in_pad_allowed: true,checkViasInPadscorrectly accepts vias inside an SMD pad. However,checkViaPadClearanceignores the same board setting and reports one false clearance error for every contained via.This affects valid thermal-pad footprints such as LCSC C7728, where thermal vias intentionally sit inside the exposed pad.
Reproduction
The test uses raw Circuit JSON containing:
It verifies that the placement check returns no errors while the clearance check incorrectly returns four errors.
This is a reproduction-only PR and does not include a fix.
Checks
bun test— 184 passed, 0 failedbunx tsc --noEmitbun run buildbun run format:checkreports only the repository's existing size-limit warnings for three large JSON fixtures; the added test passes Biome directly.