Detect traced source ports without matching PCB ports - #230
Draft
seveibar wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcb_portrunAllRoutingChecksWhy
An asynchronously loaded footprint can emit pads while failing to match those pads to source ports. In that state the source trace still exists, but existing routing checks can silently skip it when it has only one direct source port plus a named net. This allowed connected pushbuttons to render as electrically disconnected on the PCB without a check failure.
The new check fails closed at the missing endpoint: if a source port is used by a trace and its source component has a
pcb_component, that source port must have a correspondingpcb_port.Test plan
bun test(186 passing)bunx tsc --noEmitbun run build