Skip to content

fix: allow edge-contact pads for off-board components - #229

Open
itisrohit wants to merge 1 commit into
tscircuit:mainfrom
itisrohit:fix/allow-off-board-edge-contact-copper
Open

fix: allow edge-contact pads for off-board components#229
itisrohit wants to merge 1 commit into
tscircuit:mainfrom
itisrohit:fix/allow-off-board-edge-contact-copper

Conversation

@itisrohit

Copy link
Copy Markdown
Contributor

Fixes #228

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a snapshot change- was the warning/error not shown in the original snapshot?

@itisrohit
itisrohit force-pushed the fix/allow-off-board-edge-contact-copper branch from 59b2e3c to 0b1279d Compare August 20, 2026 22:27
@itisrohit

itisrohit commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

The SVG snapshot did not change because the current circuit-to-svg renderer does not visualize pcb_placement_error diagnostics. I added a Bun inline snapshot for the checker result, which is now [] after the fix, while retaining the PCB SVG snapshot for the unchanged board geometry.

@itisrohit
itisrohit requested a review from seveibar August 20, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants