Tijd om de boel te integreren? - #1
Open
dokterbob wants to merge 43 commits into
Open
Conversation
added 30 commits
September 23, 2010 12:10
since the signing code now relies on Django's settings. Either way it is not nice to assume that Django's settings is simply called settings.
secret. These are obligatory settings.
to be sure of what we're signing. Especially since later on we expect fields to be used that should not be signed at all. :)
belong here for now.
to make sure that our signatures comply.
THIS IS BROKEN CODE :)
parameters everywhere. Should all be roughly compatible with original version. Roughly.
defaults for everything.
PSP from our settings.
added 9 commits
September 24, 2010 20:06
where the URLs become tuples
Owner
|
Top al die wijzigingen :) Qua ecommerce gaan we trouwens met de volgende onderdelen aan de slag
Ik ben benieuwd hoe generiek we dat gaan krijgen. Update:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hee Thierry,
Heb inmiddels mijn refactorization gedaan. Nogal veel veranderd, heb het nog niet helemaal gedocumenteerd. Wel veel tests geschreven en (hopenlijk) de code wat overzichtelijker gemaakt.
Mocht je geen pull overwegen, of slechts een deel daarvan (de eerste 5-7 commits ofzo houden de API's redelijk intact), zou je het dan goed vinden als ik mezelf als auteur in de setup.py zet en het naar PyPI upload? Bij mijn weten is het nu redelijk stabiel allemaal...
Ben benieuwd. Ook of je nog bugs vindt (zo ja, schrijf er alsjeblieft een unittest voor om hem te repliceren!)
Groetjes,
Mathijs