fix(app): prevent url param collision between fields sheet and table filter - #175
Merged
Conversation
Updated various components to utilize the new SEARCH_PARAM constants for managing query states, enhancing consistency and maintainability across the application. This includes changes in dashboard-summary, overview-greeting, overview-scope, and several forms related to company, contact, and deal creation. Additionally, introduced tests for the SEARCH_PARAM structure to ensure no key collisions occur.
migrate deploy only adds what is missing, so a crm_test built on an abandoned branch kept that branch's tables and constraints forever. A stray trackedEvent_visitorId_fkey failed seven tracking specs on every branch. db:test now rebuilds the database when it holds a migration this branch does not have, or no longer matches schema.prisma, and --reset forces it. A missing prisma binary now reports itself instead of exiting silently.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/plan/dynamic-fields-build.md">
<violation number="1" location="docs/plan/dynamic-fields-build.md:44">
P2: The rename to `manageFields`/`manageField` was applied only to the §1 artboard table; §6 (URL state, lines 175-176, 179, 189) still tells the implementer to add `fields`/`field` params, the very names this PR renames to avoid collision. The build doc now contradicts itself on the parameter names it is meant to standardize. Update §6 to use `manageFields`/`manageField` consistently.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| | `…&fields=company&field=new` | Create a field | | ||
| | `…&fields=company&field=runs_on` | Edit a field, with coverage | | ||
| | `…&fields=company&field=runs_on (archive)` | Archive confirmation | | ||
| | `…&manageFields=company` | The fields sheet — list state | |
Contributor
There was a problem hiding this comment.
P2: The rename to manageFields/manageField was applied only to the §1 artboard table; §6 (URL state, lines 175-176, 179, 189) still tells the implementer to add fields/field params, the very names this PR renames to avoid collision. The build doc now contradicts itself on the parameter names it is meant to standardize. Update §6 to use manageFields/manageField consistently.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/plan/dynamic-fields-build.md, line 44:
<comment>The rename to `manageFields`/`manageField` was applied only to the §1 artboard table; §6 (URL state, lines 175-176, 179, 189) still tells the implementer to add `fields`/`field` params, the very names this PR renames to avoid collision. The build doc now contradicts itself on the parameter names it is meant to standardize. Update §6 to use `manageFields`/`manageField` consistently.</comment>
<file context>
@@ -41,11 +41,11 @@ Paper file **CRM**, page **crm - lewis**:
-| `…&fields=company&field=new` | Create a field |
-| `…&fields=company&field=runs_on` | Edit a field, with coverage |
-| `…&fields=company&field=runs_on (archive)` | Archive confirmation |
+| `…&manageFields=company` | The fields sheet — list state |
+| `…&manageFields=company (first run)` | Empty state |
+| `…&manageFields=company&manageField=new` | Create a field |
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened automatically when
lewis/field-fixwas pushed.The title is written from the diff and rewritten as you push, because this is squashed onto
mainand the title becomes the commit subject and the changelog line. Retitle it yourself and it is yours — the automation stops touching it.Summary by cubic
Prevents URL search-param collisions between the fields sheet and list filters, and makes the test database rebuild itself when it drifts. Previously both used the fields key and db:test left stale state; now the fields sheet uses manageFields/manageField and db:test drops and recreates crm_test if it holds foreign migrations or schema drift.
Migration
Written for commit 572724a. Summary will update on new commits.