Skip to content

Fix: copy sockinfo into local buffer before in-place split in mt_connect #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edmundlod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: copy sockinfo into local buffer before in-place split in mt_connect #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions miltertest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,7 @@ mt_connect(lua_State *l)
useconds_t interval = 0;
char *at;
char *p;
const char *sockinfo;
char sockinfo[BUFRSZ];
struct mt_context *new;

assert(l != NULL);
Expand All @@ -1406,7 +1406,15 @@ mt_connect(lua_State *l)
lua_error(l);
}

sockinfo = lua_tostring(l, 1);
/*
** lua_tostring() returns a pointer into Lua-owned storage that the
** lua_pop() below may reclaim or share with other interned strings.
** The dispatch logic NUL-terminates the protocol prefix and host part
** of this string in place, so copy it into a buffer we own first;
** mutating the Lua-owned storage (and reading it after the pop) is
** undefined behaviour.
*/
strlcpy(sockinfo, lua_tostring(l, 1), sizeof sockinfo);
if (top == 3)
{
char *f;
Expand Down