feat: Add Gerrit-style LOC bar chart to workspace stack panel - #169
Merged
Conversation
Each stacked workspace's line-change count now gets a small green/red horizontal bar sized relative to the largest change in the stack, a la Gerrit's change list. Ordering and layout of the stack card are unchanged.
Ziinc
changed the title
Insertions now grow left from a center axis line and deletions grow right, with the green +N number to the left of the bar and red -N to the right, matching Gerrit's layout more closely. Also shrinks the bar's overall footprint.
CI's check:format step failed on the DiffBar width calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+N -Nline-change count, sized relative to the largest change in the stack (à la Gerrit's change list).useQueries) so bar widths can be scaled against the stack's max change size.Test plan
WorkspaceStackPanel.test.tsxunit tests pass (6/6, unchanged assertions)scripts/screenshot/specs/stacked-workspace-panel.spec.tsxwith two differently-sized commits (+2 and +10) and verified via the screenshot harness that the bars render with visibly different widths, scaled correctlyGenerated by Claude Code