feat: Add per-file comment button to the Review tab - #167
Open
Ziinc wants to merge 2 commits into
Open
Conversation
Each file's collapsible header now has an "Add file comment" button (like GitHub's per-file comments) that opens a comment composer at the top of that file's collapsible, above the diff. Submitted comments render as editable cards in that same spot. File-level comments reuse the existing LineComment pipeline (storage, review markdown, action-bar count) via a sentinel hunkId so they never attach to a diff line and are exempt from outdated-comment detection.
Ziinc
changed the title
- Reformat the CommentInput JSX that biome's format check flagged. - Extract FileRowComponent's header (chevron, viewed toggle, add-comment button, file badges, overflow menu) into FileRowHeader, and the file-level comment thread into FileCommentSection, bringing FileRowComponent back under eslint's 500-line max-lines limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each file's collapsible header now has an "Add file comment" button
(like GitHub's per-file comments) that opens a comment composer at the
top of that file's collapsible, above the diff. Submitted comments
render as editable cards in that same spot.
File-level comments reuse the existing LineComment pipeline (storage,
review markdown, action-bar count) via a sentinel hunkId so they never
attach to a diff line and are exempt from outdated-comment detection.