[DEV] repair failing unit tests - #299
Merged
Merged
Conversation
Adding -hdd (PR #280) made the short form -hd ambiguous with -h, causing argparse to reject it. Use the full flag name in the test. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Geofabrik split czech-republic into regional sub-divisions. Replace the single 'czech-republic' entry with the 6 sub-regions that border Germany: jihocesky, karlovarsky, liberecky, plzensky, stredocesky, ustecky. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
treee111
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-hdflag ambiguity in hdd-mode tests: Adding-hddin PR [FEAT] Add GUI & CLI switch for mapwriter hdd mode #280 made the short form-hdambiguous with-h(help), causing argparse to reject it. Changed the test to use the full-hddflag.czech-republicinto regional sub-divisions. The 6 sub-regions that border Germany now appear individually in the geofabrik data instead of the singleczech-republicentry.Czech Republic region breakdown
Geofabrik divided the Czech Republic into 14 regional sub-divisions (visible at https://download.geofabrik.de/europe/czech-republic.html). The 6 sub-regions that are border countries of Germany are:
jihoceskykarlovarskylibereckyplzenskystredoceskyusteckyAny user whose
geofabrik.jsonwas downloaded after Geofabrik made this split would encounter thetest_calc_border_countries_input_countryfailure — the live data no longer matches the old hardcoded expected value.Test plan
conda run -n gdal-dev python -m unittest discover -s tests -v)🤖 Generated with Claude Code