Print inserted XML attributes and child elements - #189
Open
Shaisolaris wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186
print_XMLElement skipped an empty attrib dict and an empty child list, so the first added attribute or a new child never reached SequenceFormatter.
The formatter now always prints attrib. It also prints children when they have a non-Match edit, so an empty element does not stay self-closing over an insert. Unchanged empty elements still self-close.
Tests cover adding the first attribute, inserting a child next to text, inserting a child into an empty element, adding an attribute when one already exists, and leaving an empty element unchanged.