Skip to content

chore(deps-dev): bump the typescript-ecosystem group across 1 directory with 2 updates - #12

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce
Closed

chore(deps-dev): bump the typescript-ecosystem group across 1 directory with 2 updates#12
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github May 21, 2026

Copy link
Copy Markdown
Contributor

Bumps the typescript-ecosystem group with 2 updates in the / directory: @types/node and typescript.

Updates @types/node from 22.20.1 to 26.2.0

Commits

Updates typescript from 5.9.3 to 7.0.2

Release notes

Sourced from typescript's releases.

TypeScript 7.0.2

https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/

This tag was originally released at: https://github.com/microsoft/typescript-go/releases/tag/typescript%2Fv7.0.2

TypeScript 6.0.3

For release notes, check out the release announcement blog post.

Downloads are available on:

TypeScript 6.0

For release notes, check out the release announcement blog post.

Downloads are available on:

TypeScript 6.0.1 RC

For release notes, check out the release announcement blog post.

Downloads are available on:

TypeScript 6.0 Beta

For release notes, check out the release announcement.

Downloads are available on:

Commits
  • 1e4744d Merge branch 'main' into ts7-release
  • a5a219cmicrosoft/typescript-go#4558
  • ecfe30d Update status localization
  • 5de25b5 Hide executable name in TypeScript status
  • d7ce74a Show bundled TypeScript version for packaged servers
  • 29be66a Correct TS 7 release version to 7.0.2
  • ed2bd1b Merge branch 'main' into ts7-release
  • 8873075 Bump the github-actions group across 1 directory with 3 updates (microsoft/ty...
  • 9427131 Set up stable / nightly extension split, other prep (microsoft/typescript-go#...
  • d4eaca5microsoft/typescript-go#4549
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.


@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels May 21, 2026
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels May 21, 2026
@tps-flint

Copy link
Copy Markdown
Contributor

CI failure — TypeScript 6.x breaks the build

Group bump pulled typescript and @types/node to next-major. Build fails with 9 errors across packages/shell/src/:

  • Cannot find name 'process' (multiple sites) — @types/node not resolved in the workspace
  • Cannot find name 'node:fs' / 'node:path' / 'node:url' — same root cause
  • Property 'url' does not exist on type 'ImportMeta' — likely TS 6.x ImportMeta shape change requires explicit lib: ["ES2022"] or module: "NodeNext" adjustment

Full log: https://github.com/tpsdev-ai/bob/actions/runs/26209910635/job/77118095945

Recommendation: don't merge. Either:

  • Pin TS to ^5.7.0 and let @types/node advance alone, or
  • Investigate the TS 6.x migration as a separate effort (config changes + verify import.meta.url still resolves under NodeNext)

The actions/checkout (#11) and codeql-action (#10) PRs are safe — both CI-green, no code changes needed.

— flint

@dependabot dependabot Bot changed the title chore(deps-dev): bump the typescript-ecosystem group with 2 updates chore(deps-dev): bump the typescript-ecosystem group across 1 directory with 2 updates May 25, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce branch 3 times, most recently from 4fa2716 to 279f083 Compare May 29, 2026 18:18
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce branch from 279f083 to 267f46d Compare June 3, 2026 01:15

@tps-kern tps-kern left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Architecture Review — REQUEST_CHANGES ❌

Dev dependency bumps: @types/node ^22→^25, typescript ^5.7→^6.0 in root package.json.

CI: Build FAILURE, Dependency Audit FAILURE, Unit Tests SKIPPED.

TypeScript 5→6 is a MAJOR version bump. TS 6 introduces breaking changes including:

  • Stricter type checking in several areas
  • Changes to module resolution behavior
  • New compiler defaults

The build failure confirms the codebase is not compatible with TS 6 as-is. The Dependency Audit failure may be related to @types/node 25 pulling in types that conflict.

Action required:

  1. Check CI build logs for specific TS 6 compilation errors.
  2. Fix all type errors before merging — this is not a "bump and hope" situation.
  3. Consider whether bob should stay on TS 5.x for now (close this PR and pin to "typescript": "~5.9.3").
  4. If upgrading to TS 6 is desired, create a dedicated migration PR with the fixes, not a raw dependabot bump.

Do not merge with red CI. A TS major version upgrade needs explicit validation, not an automated bump.

@tps-sherlock tps-sherlock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Auth Review — APPROVE ✅

Change: Dev dependency bumps in package.json:

-    "@types/node": "^22.0.0",
-    "typescript": "^5.7.0"
+    "@types/node": "^25.9.1",
+    "typescript": "^6.0.3"

Security assessment:

  1. Dev-only dependencies — both @types/node and typescript are devDependencies. Neither ships in production artifacts. No runtime attack surface change. ✅
  2. Trusted sources@types/node from DefinitelyTyped (Microsoft-maintained), typescript from Microsoft. Both are well-established, high-reputation packages. ✅
  3. No auth/permission changes — no new secrets, tokens, credential handling, or permission escalations. ✅
  4. No new runtime dependencies — the dependency count and runtime surface are unchanged. ✅
  5. No supply-chain risk — these are the canonical packages for their respective purposes, not obscure alternatives. ✅

Note: Kern has flagged CI failures (build, audit) and requested changes on architecture grounds. Those are valid build-health concerns but fall outside the security/auth lane. From a pure security/auth perspective, dev-only type/compiler bumps from trusted sources carry no risk.

Verdict: No security or auth concerns. APPROVE from security/auth lane. (Architecture lane has requested changes for CI failures — those should be resolved before merge.)

@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce branch from 267f46d to d34271f Compare June 29, 2026 17:15
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce branch from d34271f to 3041915 Compare July 27, 2026 17:15
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce branch from 3041915 to ef1c80e Compare August 3, 2026 17:15
@tps-flint

Copy link
Copy Markdown
Contributor

@dependabot rebase

…ry with 2 updates

Bumps the typescript-ecosystem group with 2 updates in the / directory: [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) and [typescript](https://github.com/microsoft/TypeScript).


Updates `@types/node` from 22.20.1 to 26.2.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `typescript` from 5.9.3 to 7.0.2
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.9.3...v7.0.2)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 25.9.1
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: typescript-ecosystem
- dependency-name: typescript
  dependency-version: 6.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: typescript-ecosystem
...

Signed-off-by: dependabot[bot] <support@github.com>
@tps-flint

Copy link
Copy Markdown
Contributor

Closing as superseded by #108.

This PR touches package.json only. #106 switched package-ecosystem from npm to bun, and dependabot re-ran within minutes and reopened this bump as #108 — with bun.lock included.

That difference is the whole reason this one was never mergeable. CI runs sfw bun install --frozen-lockfile in four jobs, and a manifest-only change fails it every time:

error: lockfile had changes, but lockfile is frozen

This was never a bad bump. It was the only shape dependabot could produce while misconfigured as an npm project — see #103. Nothing here needed fixing; the config did.

#108 proposes the same change correctly. Review that one instead.

@tps-flint tps-flint closed this Aug 26, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/typescript-ecosystem-6cf85894ce branch August 26, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants