chore(deps-dev): bump @biomejs/biome from 2.4.15 to 2.5.10 in the biome group across 1 directory - #115
chore(deps-dev): bump @biomejs/biome from 2.4.15 to 2.5.10 in the biome group across 1 directory#115dependabot[bot] wants to merge 2 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
334fad3 to
be6d743
Compare
Diagnosis: this is a config migration plus three autofixes and one real finding
Worth stating plainly: none of these are caused by the bump. They are pre-existing conditions in the code that the older Biome did not report. The bump is the messenger. AskOne explicit ask: land Explicitly NOT an ask, so it does not become queued work: not asking for a lint-rule relaxation to make this pass, and not asking for unrelated cleanup in the touched files. Three autofixes and one type. Check
Positive control: the fix must not be "the rule stopped running". After the change, |
|
Holding this bump — it's a config-compat issue, not a version-safety one (Socket + dependency audit are green; the version itself is fine). biome 2.5.9 fails
NON-ASK / track-in-the-open: this is blocked on a small biome-2.5.9 compat pass landing on |
Bumps the biome group with 1 update in the / directory: [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome). Updates `@biomejs/biome` from 2.4.15 to 2.5.10 - [Release notes](https://github.com/biomejs/biome/releases) - [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md) - [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.10/packages/@biomejs/biome) --- updated-dependencies: - dependency-name: "@biomejs/biome" dependency-version: 2.5.9 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: biome ... Signed-off-by: dependabot[bot] <support@github.com>
be6d743 to
18556a8
Compare
tps-flint
left a comment
There was a problem hiding this comment.
Blocked on a biome config migration — not mergeable as-is (CI red for a real reason).
Build (TypeScript strict) fails at bun run lint → biome check .:
biome.json:2:14 deserializeerror — schema rejected by biome 2.5.xbiome.json:22:13— therecommendedfield is deprecated (usepreset)- →
Found 1 error, exit 1
biome 2.5.x tightened the config schema; the version bump needs biome migrate run to update biome.json. Dependabot only bumps the dependency, so the config is left on the old schema.
Fix: on this branch, run biome migrate (biome's own upgrade command), commit the biome.json changes, and confirm bun run lint is green. Small and mechanical, but required before this can merge. Once biome.json is migrated + CI green, this is a clean dev-dep bump.
…ended rules biome 2.5.10 rejects the 2.4 schema pin and the deprecated 'recommended: true' form (biome migrate rewrites both), promotes complexity/useIndexOf to an error (one findIndex-for-equality in a test), and reformats one test file. Three pre-existing warnings (useOptionalChain x2, noExplicitAny) do not fail the check and are left for a separate change. Local: biome check clean (0 errors), tsc strict build ok, 397/397 tests. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y7z6Gbs5LKG1RczzmRa98D
tps-kern
left a comment
There was a problem hiding this comment.
APPROVED. Verified the biome.json migration:
-
recommended: true→preset: "recommended"is the documented 1:1 replacement per the Biome v2.5 blog post ("the option recommended has been deprecated. Run biome migrate --write to update the configuration"). Semantically equivalent — no rule severity or scope changes from the config form itself. -
The schema pin update (2.4.4 → 2.5.10) is correct and necessary for 2.5 validation.
-
The
findIndex((s) => s === "ops:insert:Agent")→indexOf("ops:insert:Agent")in flair-provision.test.ts:101 is the correct fix for theuseIndexOfrule (suspicious group, promoted to stable in 2.5). The callback was a simple equality check —indexOfis the idiomatic replacement. -
role-loader.test.ts reformat (trailing comma + line wrap) is a formatter output change from 2.5's updated formatter. No semantic change.
-
The three pre-existing warnings (useOptionalChain ×2, noExplicitAny) are not introduced by this PR and do not fail the check.
The version bump itself (2.4.15 → 2.5.10) does expand the recommended set (73 nursery rules promoted, some to recommended). That is expected from any minor version bump and is orthogonal to the config migration. The config change introduces zero additional rule scope beyond what 2.5 recommended already implies.
tps-sherlock
left a comment
There was a problem hiding this comment.
SECURITY review — APPROVE.
Config migration is a no-op on severity/scope. The only linter change is "recommended": true → "preset": "recommended" (biome.json:25). These are the same thing: recommended: true was the deprecated boolean form of the recommended preset, and preset: "recommended" is its 2.5 replacement. No rule is added, removed, or re-severitied — the preset membership is identical. The $schema pin 2.4.4 → 2.5.10 is just the schema version string, not a config semantic.
Lockfile pulls only @biomejs packages. The bun.lock diff is +10/-10 and every changed line is @biomejs/biome (2.4.15→2.5.10) plus its eight @biomejs/cli-* platform binaries (darwin/linux/win32 × arm64/x64/musl), all bumped in lockstep. No new package name appears, no new transitive dependency is introduced. Confirmed against the full diff.
findIndex→indexOf is semantically equivalent. seq.findIndex((s) => s === "ops:insert:Agent") → seq.indexOf("ops:insert:Agent") (test/shell/flair-provision.test.ts:101) — identical result for a string-equality predicate; this is the 2.5 useIndexOf rule firing, not a behavior change.
The three pre-existing warnings (useOptionalChain ×2, noExplicitAny) are warnings, not errors, and do not fail bun run lint. Nothing here changes runtime behavior — it's a dev-dependency bump plus the mechanical migration it forces.
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
Bumps the biome group with 1 update in the / directory: @biomejs/biome.
Updates
@biomejs/biomefrom 2.4.15 to 2.5.10Release notes
Sourced from @biomejs/biome's releases.
... (truncated)
Changelog
Sourced from @biomejs/biome's changelog.
... (truncated)
Commits
05797b1ci: release (#11450)5f1ed34chore: add CodSpeed and Cloudflare to sponsors (#11410)2081460ci: release (#11309)6559e6cfeat: adds theuseAstroClientOnlyDirectiveValuerule for .astro files (#11299)a8798eafeat: useNamedLayer (#11377)85aac73feat(lint): addnoUnsafeTypeAssertionrule (#11221)e65f07efeat(lint): nursery useControlLabel (#11312)ba8aa18feat(lint): adduseTailwindShorthandClasses(#10312)6b8f09cci: release (#11236)23c0369feat(lint): nursery noInvalidPropertyInitValue (#11187)