fix(rules): retire noisy AWS cost heuristics - #166
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
No action required: this is a review status notification, not a code finding. |
roborev: Combined Review (
|
No action required: the combined review completed without Medium, High, or Critical findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aada6d3791
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const awsDiscoveryDatasetRegistry: { | ||
| [K in DiscoveryDatasetKey]: AwsDiscoveryDatasetDefinition<K>; | ||
| } = { | ||
| 'aws-apigateway-stages': { | ||
| datasetKey: 'aws-apigateway-stages', | ||
| resourceTypes: ['apigateway:restapis/stages'], | ||
| service: 'apigateway', | ||
| load: hydrateAwsApiGatewayStages, | ||
| toEvaluationResources: (stages) => mapEvaluationResources(stages, (stage) => stage.stageArn), | ||
| }, | ||
| 'aws-cloudtrail-trails': { |
There was a problem hiding this comment.
Remove the retired API Gateway permission from docs
After removing the API Gateway dataset, hydrator, client factory, and dependency, live discovery no longer makes GetStage calls, but docs/architecture/sdk.md:113 still tells operators that scans require apigateway:GetStage. This leaves the documented operational IAM requirements inconsistent with the implementation and can cause users to retain unnecessary access; update that permission list in the same change.
AGENTS.md reference: AGENTS.md:L23-L25
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in be008c8. Removed apigateway:GetStage from the live-discovery IAM permission reference so the documented access matches the remaining hydrators.
Summary
These heuristics produced findings without proving that the flagged configuration would save money. Retiring them keeps default scans focused on findings backed by utilization or direct cost evidence.
Scope
cloudburn(cli)@cloudburn/sdk@cloudburn/rulesRelease Notes
.changeset/*.mdfile for published package changesVerification
pnpm lintpnpm typecheckpnpm testpnpm buildpnpm verifypnpm docs:testBoundary Checks
@cloudburn/rulesRelated Issues
None.