feat(mobile): absorb @react-simplikit/mobile into the react-simplikit/mobile subpath - #437
Draft
mnxmnz wants to merge 5 commits into
Draft
feat(mobile): absorb @react-simplikit/mobile into the react-simplikit/mobile subpath#437mnxmnz wants to merge 5 commits into
mnxmnz wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 3ba2277 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: -650 B (-0.66%) Total Size: 98 kB 📦 View Changed
ℹ️ View Unchanged
|
mnxmnz
force-pushed
the
433-absorb-mobile
branch
from
August 25, 2026 16:55
f309760 to
031fedd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 433-rename-core #437 +/- ##
=================================================
Coverage 100.00% 100.00%
=================================================
Files 58 58
Lines 1652 1652
Branches 499 499
=================================================
Hits 1652 1652 🚀 New features to boost your workflow:
|
mnxmnz
force-pushed
the
433-absorb-mobile
branch
from
August 25, 2026 17:38
c326f3f to
3ba2277
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Closes #433. Absorb
@react-simplikit/mobileinto the main package as thereact-simplikit/mobilesubpath. The mobile export surface is byte-identical to the old package — only the package boundary moves.packages/mobile/src→packages/react-simplikit/src/mobile; duplicated test utils merged into_internal/test-utils, and the React Compiler canary now also proves mobile source gets compiled.package.json:exports["./mobile"]+typesVersions(node10 type resolution; verified load-bearing via attw), tsdown builds a second entry.packages/mobileremoved; examples now importreact-simplikit/mobile.check-changespath filter andverify-exportsnow coversrc/mobile, and verify-pack runs per-entry tree-shaking gates (root 256B, mobile 768B).Decisions made in this PR — open to review:
import from 'react-simplikit'.typesVersionsasymmetry: legacymoduleResolution: "node"consumers get types but not runtime resolution for the subpath. Modern toolchains are unaffected; if we want legacy support, amobile/package.jsonproxy stub can be added later.npm deprecate @react-simplikit/mobile "Moved into react-simplikit/mobile subpath"— recorded in the changeset; changesets can no longer version the removed package.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line? (100% maintained)