feat(settings): add in-app theme mode override (System/Light/Dark) - #1077
Open
darky wants to merge 7 commits into
Open
feat(settings): add in-app theme mode override (System/Light/Dark)#1077darky wants to merge 7 commits into
darky wants to merge 7 commits into
Conversation
Contributor
Greptile SummaryThe PR adds a persisted System/Light/Dark appearance override and applies the effective mode across the main UI, theme editor, previews, incoming-call UI, and system bars.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
UI[Theme mode chips] --> VM[SettingsViewModel]
VM --> Repo[SettingsRepository]
Repo --> DS[Preferences DataStore]
DS --> State[ThemeMode Flow]
State --> Main[MainActivity / ColumbaTheme]
State --> Call[IncomingCallActivity]
Main --> Editor[Theme editor and preview]
Main --> Bars[Status and navigation bars]
Call --> Bars
Reviews (7): Last reviewed commit: "fix(calls): render incoming controls imm..." | Re-trigger Greptile |
# Conflicts: # app/src/main/res/values/strings.xml
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1074