Add iOS background propagation sync - #154
Merged
Merged
Conversation
Contributor
Greptile SummaryThe PR adds iOS background propagation-node synchronization and hardens the previously reported cancellation lifecycle.
Confidence Score: 5/5The PR appears safe to merge because the previously reported cancellation races are addressed and no blocking failure remains. The operation ID prevents stale Swift cancellation from targeting a later sync, while the Python condition-protected operation slot remains occupied until router-wide cancellation finishes, preventing late teardown from reaching a successor request. Important Files Changed
Sequence DiagramsequenceDiagram
participant iOS as BGTaskScheduler
participant Runtime as ColumbaApplicationRuntime
participant Manager as PropagationNodeManager
participant Bridge as PythonBridge
participant Router as Python LXMRouter
iOS->>Runtime: Deliver background refresh
Runtime->>Runtime: Ensure shared services initialized
Runtime->>Manager: syncNow(operationID)
Manager->>Bridge: propagationSyncAndDrain(timeout)
Bridge->>Router: Start propagation request
alt Refresh expires
iOS-->>Runtime: Expiration handler
Runtime->>Manager: cancelActiveSync(operationID)
Manager->>Bridge: cancelPropagationSync()
Bridge->>Router: Cancel active request
Router-->>Bridge: Teardown complete
else Sync completes
Router-->>Bridge: Result and queued events
Bridge-->>Manager: Transaction
Manager-->>Runtime: Success
end
Runtime-->>iOS: Complete refresh task
Reviews (4): Last reviewed commit: "test: handle escaped Swift multiline del..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BGAppRefreshTaskregistration, retention, scheduling reconciliation, and exactly-once completion for iOS propagation synchronizationVerification
2a68ef5a980c310e1a710ac92debd9e8f32d6db6py_compile: passedgit diff --check: passedfetchandnetwork.columba.Columba.syncinitialized=falseat entryScheduling and presentation limitations
earliestBeginDateis a not-before date, not a deadline or guaranteed cadence; iOS retains control over whether and when the task runsBGAppRefreshTaskexposes no public priority, urgency, QoS, or deadline controlRisk / rollback