Show automatically selected relay in Settings - #153
Merged
Conversation
Contributor
Greptile SummaryThe PR replaces Settings’ cached relay-name display with the live selection owned by PropagationNodeManager and adds a static regression contract preventing a return to the stale SettingsViewModel snapshot.
Confidence Score: 5/5The PR appears safe to merge with no identified blocking or non-blocking issues. Settings is presented only after AppServices initialization installs the observable propagation manager, and direct observation of selectedNodeName provides the intended live relay updates. Important Files Changed
Reviews (1): Last reviewed commit: "fix: show live selected relay" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PropagationNodeManagerRoot cause
Propagation sync could automatically select and use a relay while Settings continued rendering a snapshot copied into
SettingsViewModel. That snapshot was not refreshed when relay discovery selected a node after the screen loaded.Verification
python3 -m pytest Tests/static -qgit diff --checkNative simulator verification is delegated to the repository CI lanes because the local Mac transfer gate blocked the committed bundle before Xcode execution.
Risk
Low. The change only replaces the stale Settings snapshot read with the existing observable propagation manager state. Relay selection, persistence, and sync behavior are unchanged.