fix: preview and export received attachments - #150
Merged
Conversation
Contributor
Greptile SummaryThe PR makes received image and file attachments interactive and presents their original bytes through native Quick Look.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Bubble as MessageBubble
participant Timeline as MessageTimelineViewController
participant Chat as MessagingView
participant Item as PreviewItem
participant QL as Quick Look
User->>Bubble: Tap image or file chip
Bubble->>Timeline: Attachment callback + stable index
Timeline->>Chat: Open attachment
Chat->>Item: Write original bytes to isolated temp URL
Item-->>Chat: Preview URL
Chat->>QL: Present URL
QL-->>User: Preview and native export actions
User->>QL: Dismiss
QL->>Chat: Clear URL binding
Chat->>Item: Clean owned temporary directory
Reviews (2): Last reviewed commit: "fix: make attachment taps exclusive with..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #145
Verification
xcodebuild teston the shippingColumbascheme: 278 tests, 0 failuresColumba-ModelBsimulator build: succeededSave Image/Save to FilesNotes
On the iOS 26.4 Simulator, selecting
Save to Filesreturns directly to Quick Look rather than presenting a second picker-levelSavecontrol. The interop lane therefore verifies selection of the named native action and byte identity at Quick Look's active export URL; it does not claim destination Files-container readback.Two unrelated project-graph contracts remain baseline failures on the merged PR #149 baseline and are unchanged by this branch.
Risk and rollback
The change is scoped to attachment presentation and temporary export files. It does not alter LXMF encoding, persistence, database schema, or the messaging backend. Reverting this PR restores the previous noninteractive attachment rendering.