Complete NomadNet navigation and canonical Micron rendering - #148
Merged
Conversation
Contributor
Greptile SummaryThis PR completes NomadNet request-link navigation and substantially expands canonical Micron parsing and rendering.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect established. Request navigation, bridge framing, parsing, rendering, recursive partial loading, and shared-address handling remain internally consistent and are covered by focused regression tests. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant View as NomadNetBrowserView
participant VM as NomadNetBrowserViewModel
participant Service as NomadNetBrowserService
participant Backend as RnsNomadnet
participant Node as NomadNet Node
User->>View: Tap request-bearing Micron link
View->>VM: handleLinkTap(link)
VM->>VM: "Build field_* and var_* request context"
VM->>Service: submitRequest(destination, path, requestData)
Service->>Backend: fetchNomadNetPage(..., formFields)
Backend->>Backend: Resolve cold path and establish link
Backend->>Node: RNS request with mapping
Node-->>Backend: Micron response
Backend-->>Service: NomadNetFetchResult
Service-->>VM: Parsed MicronDocument
VM->>VM: Preserve variables in location/history
VM-->>View: Render page and recursive partials
Reviews (1): Last reviewed commit: "test: prove cold NomadNet link request" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rngitrequest-link navigation with canonicalvar_request semantics while excluding user-enteredfield_values from reusable addressesAuthority and development approach
Behavior is aligned with canonical NomadNet request and Micron semantics. The feature was developed through red/green regression coverage spanning parser, rendering, request framing, address round trips, recursive document loading, viewport geometry, and cold-path resolution.
Verification
Physical verification used a local integration artifact that also contained the separate accepted composer fix from PR #147. This PR excludes PR #147 and contains only the complete NomadNet feature stack described above.
Risk and rollback
Primary risk is behavioral compatibility across complex Micron nesting/render modes and NomadNet address/request edge cases. Regression coverage exercises canonical colors, reset behavior, recursive partials, history/reopen semantics, request payload ownership, and cold resolution. Rollback is a normal revert of this feature branch; there are no data migrations or generated artifacts.