Skip to content

Derive release versions from tags - #34

Merged
ggoodman merged 3 commits into
mainfrom
codex/tag-derived-release-version
Jul 27, 2026
Merged

Derive release versions from tags#34
ggoodman merged 3 commits into
mainfrom
codex/tag-derived-release-version

Conversation

@ggoodman

Copy link
Copy Markdown
Contributor

Summary

  • make the GitHub release tag authoritative for the npm package version
  • generate package.json and package-lock.json versions inside both release verification and publishing jobs
  • keep committed package metadata at the 0.0.0 sentinel and require an explicit version for manual workflow recovery

This removes release-only version bump commits and aligns Sledge with the release-driven package versioning used by code-mode and Sandbox.

Verification

  • node --run lint
  • node --run typecheck
  • node --run test (128 passing)
  • node --run build
  • generated-version simulation with npm version 9.8.7 --no-git-tag-version

Copy link
Copy Markdown
Contributor Author

@codex review

1 similar comment

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0cff5c5e0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Outdated

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8748ca3cde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Outdated

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 430e7a79ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ggoodman
ggoodman merged commit 04a31e3 into main Jul 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant