chore(mcp): test against Node 22 and 24, and declare an engines range - #11
Merged
Conversation
The MCP server is published to npm, so it runs on whatever Node a
consumer has, but CI only ever exercised a single version and the
package made no claim about what it supports.
Run the mcp job as a matrix over Node 22 and 24 - the two lines still
receiving updates now that 20 is end of life - with fail-fast disabled
so a break on one version doesn't mask the result on the other. Both
legs are short Linux jobs, so the added cost is negligible.
Declare "engines": { "node": ">=22" } to match. This is a support
statement rather than a technical floor: src/index.ts needs global
fetch and nothing more exotic, so it may well run on older releases,
but 22 is the oldest version actually covered by CI.
Renovate bumped this pin in #10 while it was a plain scalar; it cannot
do the same for a matrix list, so the versions are now maintained by
hand and a comment says so.
Note that the check names change from "MCP server" to
"MCP server (node 22)" and "MCP server (node 24)", which matters if
required status checks are ever configured on main.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10. Two related gaps that bump surfaced.
Node matrix
mcp/is published to npm as@evoio/apple-bridge-mcp, so it runs on whatever Node a consumer has — but CI only ever exercised one version. #10 moved that from 22 to 24, which silently dropped 22 from coverage entirely.22 and 24 are the two lines still receiving updates now that 20 is EOL.
fail-fast: falseso a break on one version doesn't mask the other's result. Both legs are ~15s Linux jobs.enginesThe package previously made no claim at all, so consumers got no signal at install time.
This is a support statement, not a technical floor.
src/index.tsneeds globalfetchand nothing more exotic — no top-level await — so it may well run on older releases. 22 is simply the oldest version CI actually covers. If you want the real floor, add 20 to the matrix temporarily and see what breaks.Also note npm only warns on an engines mismatch unless the consumer sets
engine-strict=true.package-lock.jsonpicked up the matchingenginesentry vianpm install --package-lock-only, so the lock doesn't drift on the next install.Two consequences worth knowing
Renovate loses this pin. #10 worked because
node-version: 24was a plain scalar it could regex. It cannot bump a matrix list, so these versions are hand-maintained now — there's a comment in the workflow saying so, pointing at theenginesrange to keep them in step.Check names change from
MCP servertoMCP server (node 22)/MCP server (node 24). No effect today, but that's what you'd name if required status checks are ever configured onmain.Verification
npx js-yamlparses the workflow; matrix resolves to[22, 24],node-versionwired to${{ matrix.node }}npm ciclean, typecheck clean, 21/21 tests🤖 Generated with Claude Code